Skip to content

feat(FR-1499): implement delete and restore artifacts #4317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

feat(FR-1499): implement delete and restore artifacts #4317

merged 1 commit into from
Sep 25, 2025

Conversation

@nowgnuesLee
Copy link
Contributor

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

This was referenced Sep 22, 2025
Merged
Merged
Closed
@github-actions github-actions bot added the size:L 100~500 LoC label Sep 22, 2025
This was referenced Sep 22, 2025
Closed
Merged
Merged
@nowgnuesLee Graphite App
Copy link
Contributor Author

nowgnuesLee commented Sep 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee mentioned this pull request Sep 22, 2025
Merged
5 tasks
@github-actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

Coverage report for ./packages/backend.ai-ui

St.❔
 Category Percentage Covered / Total
🔴 Statements 52.42% 130/248
🔴 Branches 32.26% 80/248
🔴 Functions 35.09% 20/57
🔴 Lines 54.84% 119/217

Test suite run success

55 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 780880d

@github-actions
Copy link

github-actions bot commented Sep 22, 2025 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
4.47% (+1.13% 🔼)
 501/11215
🔴 Branches
3.63% (+0.46% 🔼)
 285/7849
🔴 Functions
2.57% (+0.53% 🔼)
 90/3501
🔴 Lines
4.44% (+1.14% 🔼)
 487/10964

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 780880d

@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from b1378d4 to a425f85 Compare September 23, 2025 07:18
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 5b923f1 to f835903 Compare September 23, 2025 07:18
@yomybaby yomybaby force-pushed the feat/delete-and-restore-artifacts branch from a425f85 to 93c6561 Compare September 23, 2025 09:57
@yomybaby yomybaby force-pushed the feat/update-pulling-artifact branch from f835903 to 7e41efa Compare September 23, 2025 09:57
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 93c6561 to 5da3853 Compare September 23, 2025 15:25
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 7e41efa to 17e6099 Compare September 23, 2025 15:25
@nowgnuesLee nowgnuesLee mentioned this pull request Sep 23, 2025
Merged
5 tasks
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 5da3853 to 3185d5c Compare September 23, 2025 15:54
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC and removed size:L 100~500 LoC labels Sep 23, 2025
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 3185d5c to 5357af0 Compare September 23, 2025 15:57
@nowgnuesLee nowgnuesLee marked this pull request as ready for review September 23, 2025 15:57
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch 3 times, most recently from 5796a5c to 78e0e2d Compare September 25, 2025 01:25
yomybaby
yomybaby requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As shown in the attached video, the restored item does not immediately disappear from the list. Please take a look.

iShot_2025-09-25_12.02.08.mp4 (uploaded via Graphite)

@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 78e0e2d to fa9f843 Compare September 25, 2025 04:20
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 17e6099 to 81e214d Compare September 25, 2025 04:20
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch 2 times, most recently from cf95576 to ee2db40 Compare September 25, 2025 05:06
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 81e214d to 4dfe10a Compare September 25, 2025 05:06
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch 3 times, most recently from ee60edb to b436c15 Compare September 25, 2025 06:30
@nowgnuesLee nowgnuesLee force-pushed the feat/update-pulling-artifact branch from 4dfe10a to 004a503 Compare September 25, 2025 06:30
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from b436c15 to 07358a1 Compare September 25, 2025 07:02
@yomybaby yomybaby force-pushed the feat/update-pulling-artifact branch from 004a503 to c9ea4ac Compare September 25, 2025 08:33
@yomybaby yomybaby force-pushed the feat/delete-and-restore-artifacts branch from 07358a1 to 7d45f5e Compare September 25, 2025 08:33
yomybaby
yomybaby approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link

graphite-app bot commented Sep 25, 2025 •
edited
Loading

Merge activity

@nowgnuesLee
feat(FR-1499): implement delete and restore artifacts (#4317)
780880d 
resolves #NNN (FR-MMM)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the feat/update-pulling-artifact branch from c9ea4ac to 176ee48 Compare September 25, 2025 09:03
@graphite-app graphite-app bot force-pushed the feat/delete-and-restore-artifacts branch from 7d45f5e to 780880d Compare September 25, 2025 09:04
Base automatically changed from feat/update-pulling-artifact to main September 25, 2025 09:07
@graphite-app graphite-app bot merged commit 780880d into main Sep 25, 2025
9 checks passed
@graphite-app graphite-app bot deleted the feat/delete-and-restore-artifacts branch September 25, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@nowgnuesLee nowgnuesLee

Labels

area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nowgnuesLee @yomybaby